Add Zen browser cookie import + real vendor icons in picker#16
Merged
Conversation
Zen is a Firefox fork that ships the same plain `cookies.sqlite` layout, so the existing Firefox reader handles it — all this needed was the enum case, the `~/Library/Application Support/zen/` data root, and generalising `firefoxCookieStores` to take a browser parameter. Also swaps the SF Symbol globe in the import picker for each browser's real logo, bundled under `Assets.xcassets/Browsers/`. `Picker(.menu)` flattens to NSPopUpButton and ignores SwiftUI frame modifiers on vector assets, so the closed-state was rendering SVGs at their native viewBox size. Switched to `Menu` with a SwiftUI label and a pre-sized `NSImage` helper for both closed-state and NSMenu rows. Closes #12
The repository ruleset requires a status check named `ci`, but the workflow's job published `Build & Test (macOS 15)`, so the required check never reported and PRs stayed in "waiting on status" forever. Rename the job so its check-run name matches the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cookies.sqlitelayout, so the existing Firefox reader handles it once the enum case, data root (~/Library/Application Support/zen/), and a generalisedfirefoxCookieStores(for:)are in place.Assets.xcassets/Browsers/(SVGs withpreserves-vector-representation, plus a PNG for Helium).Picker(.menu)withMenu:Picker(.menu)flattens toNSPopUpButtonand ignores SwiftUIframeon vector assets, so SVGs rendered at their native viewBox size.Menuwith a SwiftUI closed-state label + a pre-sizedNSImagehelper (for NSMenu rows) keeps both at 16×16.Test plan
xcodebuild -scheme YouMenuTube buildcleanfirefoxCookieStores)